Re: [PATCH ath-next 1/3] wifi: ath10k: set the PMF peer flag on WCN3990

[David Heidelberg]

On 02/11/2026 23:51, Nagashima, Shunsuke wrote:
> Hi Loic,
>
> On Mon, Nov 2, 2026 at 12:56 PM Loic Poulain wrote:
> > So why not updating firmware-5.bin file instead?
> >
> > There is a tool available here:
> > https://github.com/qca/qca-swiss-army-knife.git
>
> Thank you for the suggestion and for the pointer to ath10k-fwencoder.
>
> I had tried that first. On my comma four, a local firmware-5.bin with
> the mfp-support bit set gave the same result as this patch: the
> protected Deauth carried a live PN, and the next association was not
> rejected. It is also the file I used for the overnight PMF runs in the
> notes of patch 3.
>
> I went for a driver change instead for two reasons:
>
>   - I was not sure whether it was fine to change a firmware file that
>     Qualcomm provides.
>   - Other devices seemed to have the same problem. No WCN3990
>     firmware-5.bin in linux-firmware sets the bit, including the newest
>     one (shikra), and Aleksei (WCN3988) and Conn (QCA9377) reported the
>     same issue in this thread.
>
> So I'll drop this patch and send a firmware-5.bin update to
> linux-firmware instead. Patches 2 and 3 do not depend on this one.
> Should the update change the shared WCN3990/hw1.0/firmware-5.bin, or
> add a file for one board?

ath10k-fwencoder --modify --features=wowlan,mgmt-tx-by-ref,non-bmi,mfp-support 
firmware-5.bin

for the OnePlus 6 (oneplus,enchilada) issue "speed not exceeding 10Mbit issue" 
on the WPA3 enabled router for too.

David

> Aleksei, Conn: a firmware file update only helps devices that load that
> file. If you have time, could you make the same change to the
> firmware-N.bin your device loads, test it, and send it to
> linux-firmware?
>
> I worked through this with Claude (AI). English is hard for me, so AI
> helped write the English. I ran all the device tests myself on my comma
> four.
>
> Thanks,
> Shunsuke Nagashima <shunsuke@xxxxxxxxxx>