Re: [PATCH net v2 0/5] net: mvneta: fix the TX queue arbitration and the mqprio offload

[Josef Schlehofer]

Hi Maxime,

On 11/3/26 19:56, Maxime Chevallier wrote:
> Wouldn't this break mqprio offload ? It's no longer priorising then ?
>
> That behaviour of the high-prio queue potentially starving the other
> is likely what mqprio users actually need, so maybe we need to setup
> prio-based queue selection when adding an mqprio qdisc, and switch back
> to WRR when its removed ?

You're right, it does. In v3 I switch the queues back to fixed priority
while an mqprio offload is set up, and to WRR when it is removed, as
you suggest.

I tested it on the Omnia. With the offload, the higher traffic class
still takes the whole link (94 vs 0.2 Mbit/s). Without it, the busy
queues share the link equally.

For patch 2 I added one thing to the commit message: if taprio replaces
the offload under a new handle, it ends up without traffic classes and
sends nothing, like after a software mqprio. The code is the same, so I
kept your Reviewed-by. Hope that's OK.

I'd like to send v3 later today. Thanks for the reviews!

Josef

pw-bot: cr