Re: [PATCH v2 2/3] dt-bindings: usb: starfive,jhb100-dwc3: Add clock number limit

From: Minda Chen

Date: Wed Nov 04 2026 - 06:41:27 EST


>
> On Tue, Nov 03, 2026 at 02:48:35PM +0800, Minda Chen wrote:
> > StarFive JHB100 device controller do not connect with PHY but connect
> > with digital adapter module. So it do not
>
> Please use any grammar check tool.
>
Okay
> > contain core reference clock. So the minimal clock number is 2 (glue
> > layer main enable clock and dwc3 core bus clk). So Add minItem 2 to
> > clock and clock-names items.
>
> So the binding is completely wrong? I see no logic in this explanation.
> You claim device DOES NOT connect with a phy, which would imply some
> removal, but you did not remove anything but made it optional. So it does
> connect with a phy?
>
> Impossible to parse/understand.
>
Thanks for review.
Compared with normal usb with PHY, USB device need to remove reference clock.

Below is USB device dts example, I will add this to commit message.
usb@10680000 {
compatible = "starfive,jhb100-dwc3";
reg = <0x10680000 0x10000>,
<0x10695800 0x100>;
reg-names = "core", "adapter";
clocks = <&usbdcrg 30>,
<&usbdcrg 31>;
clock-names = "main", "bus_early";
....
};

Below is normal usb with PHY example dts setting in dt-binding doc(do not require usb PHY setting)
usb@11800000 {
compatible = "starfive,jhb100-dwc3";
reg = <0x11800000 0x10000>;
reg-names = "core";
clocks = <&usbcrg 9>,
<&usbcrg 5>,
<&usbcrg 6>;
clock-names = "main", "bus_early", "ref";
....
};

So the change is compact with two kinds of dwc3 USB controller.