Re: [PATCH v3 2/9] media: mgb4: use dmaengine_desc_set_callback()

[Martin Tůma]

On 11/3/26 4:37 PM, Frank.Li@xxxxxxxxxxx wrote:
> From: Frank Li <Frank.Li@xxxxxxx>
>
> Replace open-coded assignments to callback and callback_param fields
> of struct dma_async_tx_descriptor with calls to the
> dmaengine_desc_set_callback() helper.
>
> No functional change intended. Prepare to make struct
> dma_async_tx_descriptor private to the DMA engine.
>
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---
> change in v3
>    split to simple patch
> https://lore.kernel.org/imx/38f6a9abf37b06318bb6429ac04807941ca8d558.camel@xxxxxxxxxxxxx/
> ---
>   drivers/media/pci/mgb4/mgb4_dma.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/pci/mgb4/mgb4_dma.c b/drivers/media/pci/mgb4/mgb4_dma.c
> index cae888e6504b0..c9a15c625be65 100644
> --- a/drivers/media/pci/mgb4/mgb4_dma.c
> +++ b/drivers/media/pci/mgb4/mgb4_dma.c
> @@ -55,8 +55,7 @@ int mgb4_dma_transfer(struct mgb4_dev *mgbdev, u32 channel, bool write,
>   		return -EIO;
>   	}
>   
> -	tx->callback = chan_irq;
> -	tx->callback_param = chan;
> +	dmaengine_desc_set_callback(tx, chan_irq, NULL, chan);
>   
>   	ret = dma_submit_error(dmaengine_submit(tx));
>   	if (ret) {

Acked-by: Martin Tůma <martin.tuma@xxxxxxxxxxxxxxxxxxxxx>