Re: [PATCH v2 5/5] ASoC: rt721-sdca: wait for PDEs to reach PS0 after powering them up

[Pierre-Louis Bossart]

On 11/3/26 21:05, Matthew Schwartz wrote:
> The PDE event handlers write REQUESTED_PS and return, so DAPM unmutes
> the feature unit and the stream starts while the power domain is still
> transitioning. On the ASUS ROG Xbox Ally X20 the first headset mic
> capture after the capture path powers down starts with about 0.45 s
> pinned at full scale, and the DisCo tables give the jack function PDEs
> up to 500 ms to reach PS0.
> 
> Poll ACTUAL_PS with sdca_asoc_pde_poll_actual_ps() after each power up,
> like rt722 does since its DMIC pop noise fix, and use the 500 ms maximum
> for the jack function PDEs. Power down is left alone because ACTUAL_PS
> can stay at PS0 while the data port is still running.

Sounds like the right thing to do

Reviewed-by: Pierre-Louis Bossart <pierre-louis bossart@xxxxxxxxx>

IIRC there was a good regmap-related reason why we split the write to
REQUESTED_PS, and the wait on ACTUAL_PS, but the net result is that some
folks don't wait...