Re: [PATCH 4/4] irqchip/alpine-msi: Add debug logging for MSI allocation

[Radu Rendec]

On Sat, 2026-10-24 at 19:33 +0000, Farber, Eliav wrote:
> On Sat, 2026-10-24 at 14:47 -0400, Radu Rendec wrote:
> > On Wed, 2026-09-23 at 08:37 +0000, Eliav Farber wrote:
> > > Add log messages to help follow the driver flow when debugging: an
> > > info message on successful initialisation, and debug messages on the
> > > MSI interrupt allocation and free paths.
> 
> [...]
> 
> > > +    pr_info("initialized successfully, spi %d to %d\n",
> > > +            priv->spi_first, priv->spi_first + priv->num_spis - 1);
> > > +
> > >      retain_and_null_ptr(priv);
> > >      retain_and_null_ptr(msi_map);
> > >      return 0;
> > 
> > Not that this matters in reality (because all these numbers are "small")
> > but for the sake of correctness: all the variables you added messages
> > for are unsigned, so you should use %u on them.
> 
> Thanks for the review. Fixed in v2: all the new messages use %u.

You're welcome. Thanks for fixing it and sorry for the late reply!

> > Since you're cleaning up this driver, you may want to look at the other
> > prints. For example, the existing pr_debug() in alpine_msix_init() has
> > the same problem.
> 
> Fixed in a separate patch in v2, which also corrects the wording of that
> message. The other prints in the driver are pr_err() calls without any
> arguments, so nothing else needed changing.

Sounds good, thanks!

-- 
Radu