Re: [PATCH v2 1/3] dt-bindings: usb: qcom,snps-dwc3: Add mode-switch
From: Krzysztof Kozlowski
Date: Wed Nov 04 2026 - 08:24:41 EST
On Tue, Nov 03, 2026 at 10:50:55PM +0900, Joonhoe Kim wrote:
> The QMP USB3-DP combo PHY stops the USB3 PIPE clock when a Type-C
> DisplayPort pin assignment gives it all four lanes for DisplayPort,
> while the controller can keep running its USB 2.0 port. The controller
> has to move to the UTMI clock before that happens, so it needs the
> Type-C mux state as well. fwnode_typec_mux_get() only matches graph
Controller does not perform the switch, does it?
> nodes that have the "mode-switch" property, so allow it on the
> controller node.
So judging by this, you would need to fix fwnode_typec_mux_get() or
opther driver code, not the binding?
>
> Signed-off-by: Joonhoe Kim <26rote@xxxxxxxxx>
> ---
> v2:
> - Use the common usb-switch schema instead of a local definition
>
> Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> index b77c02c64d45..14fc7e4ebc80 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> @@ -158,6 +158,8 @@ properties:
> HS/FS/LS modes are supported.
> type: boolean
>
> + mode-switch: true
Drop, but you might explicitly disallow orientation and retimer, if
entire solution stays after review.
Best regards,
Krzysztof