[PATCH 1/3] ata: libata-transport: drop the dead GSCR newline check
From: shao.mingyin
Date: Wed Nov 04 2026 - 08:27:33 EST
From: Shao Mingyin <shao.mingyin@xxxxxxxxxx>
SATA_PMP_GSCR_DWORDS is 128, so "SATA_PMP_GSCR_DWORDS & 3" is always
zero and the branch is dead. The loop already terminates every fourth
dword with a newline.
No functional change.
Signed-off-by: Shao Mingyin <shao.mingyin@xxxxxxxxxx>
---
diff --git a/drivers/ata/libata-transport.c b/drivers/ata/libata-transport.c
index 95862dc34419..bebccda4d710 100644
--- a/drivers/ata/libata-transport.c
+++ b/drivers/ata/libata-transport.c
@@ -447,8 +447,6 @@ show_ata_dev_gscr(struct device *dev,
ata_dev->gscr[i],
((i+1) & 3) ? ' ' : '\n');
}
- if (SATA_PMP_GSCR_DWORDS & 3)
- buf[written-1] = '\n';
return written;
}