Re: [PATCH v2 2/2] arm64: dts: qcom: lemans-sa8255p: add ethernet nodes

[Bartosz Golaszewski]

On Wed, Nov 04, 2026 at 08:44:35PM +0800, Shawn Guo wrote:
> On Tue, Nov 03, 2026 at 11:42:00AM +0100, Bartosz Golaszewski wrote:
> > Add the ethernet nodes along with their serdes PHY nodes for the gearvm
> > variant of the lemans ride board. Enable scmi7 and scmi8 to serve the
> > EMACs.
> > 
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi      |  30 ++++
> >  arch/arm64/boot/dts/qcom/lemans-sa8255p-ride.dts | 207 +++++++++++++++++++++++
> >  2 files changed, 237 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi b/arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi
> > index 91c97a55f2787406b104650956b9a511a6a34c23..96a54f32f0eeb16dbce9802e74eec82622ecd35f 100644
> > --- a/arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi
> > @@ -58,6 +58,18 @@ &cpufreq_hw {
> >  	clock-names = "xo", "alternate";
> >  };
> >  
> > +&ethernet0 {
> > +	compatible = "qcom,sa8255p-ethqos";
> > +	phys = <&serdes0>;
> > +	phy-names = "serdes";
> > +};
> > +
> > +&ethernet1 {
> > +	compatible = "qcom,sa8255p-ethqos";
> > +	phys = <&serdes1>;
> > +	phy-names = "serdes";
> > +};
> > +
> >  &firmware {
> >  	scmi0: scmi-0 {
> >  		compatible = "qcom,scmi-smc";
> > @@ -3218,6 +3230,24 @@ &uart21 {
> >  			     "perf";
> >  };
> >  
> > +&soc {
> > +	serdes0: phy@8901000 {
> > +		compatible = "qcom,sa8255p-dwmac-sgmii-phy";
> > +		reg = <0x0 0x08901000 0x0 0xe10>;
> > +		#phy-cells = <0>;
> > +		power-domains = <&scmi7_dvfs 0>;
> > +		status = "disabled";
> > +	};
> 
> We have the serdes node for Embedded variant as well.
> 
>         serdes0: phy@8901000 {
>                 compatible = "qcom,sa8775p-dwmac-sgmii-phy";
>                 reg = <0x0 0x08901000 0x0 0xe10>;
>                 clocks = <&gcc GCC_SGMI_CLKREF_EN>;
>                 clock-names = "sgmi_ref";
>                 #phy-cells = <0>;
>                 status = "disabled";
>         };
> 
> Per Nord discussion with Konrad [1], I plan to move serdes nodes back to
> common DTSI and let variant DTSI to supplement or overwrite properties
> as needed. Does that make sense?
>

Yes, it'll be in line with emac nodes. I'll wait for your next series
before resending this series.

Thanks,
Bartosz

PS Please try to trim your responses, don't include the entire long
patch if you're only commenting on a fragment of it.