Re: [PATCH] ALSA: hda: cs35l56: Stop cs_dsp before calling cs_dsp_power_down()

[Takashi Iwai]

On Wed, 04 Nov 2026 13:23:37 +0100,
Richard Fitzgerald wrote:
> 
> In cs35l56_hda_unbind() call cs_dsp_stop() before cs_dsp_power_down()
> if cs_dsp is in a running state.
> 
> cs35l56_hda_runtime_resume() calls cs_dsp_run() if cs_dsp_power_up() has
> previously run successfully. If cs35l56_hda_unbind() is then called while
> in this runtime-resumed state cs_dsp will be running. The code wasn't
> checking for this and was calling cs_dsp_power_down() while still in a
> running state, which is illegal. This is currently fairly harmless for
> the cs35l56 driver. But it doesn't comply with the API, so potentially
> could break with any future changes that expect the correct API use.
> 
> Fixes: fb78d73dde2d4 ("ALSA: hda/cs35l56: Call cs_dsp_power_down() before calling cs_dsp_remove()")
> Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>

Applied now.  Thanks.


Takashi