Re: [PATCH 1/2] arm64: dts: rockchip: enable OV9281 CAM0 P14 on RK3588 Jaguar

[Quentin Schulz]

On 11/2/26 9:30 PM, Quentin Schulz wrote:
[...]
> +	eeprom@50 {
> +		compatible = "st,24c64", "atmel,24c64";

Turns out I was looking at the wrong schematics and this here is a 
TD24C64-C-A EEPROM which seems to be from "Shenzhen Tudi Semiconductor 
Co., Ltd.". There's no vendor for that in the bindings, and not sure 
it's worth adding one for? I'll keep the ST one unless told otherwise.

[...]

> +	imu@6a {
> +		compatible = "st,lsm6dsr";
> +		reg = <0x6a>;
> +		interrupt-parent = <&gpio1>;
> +		interrupts = <RK_PC0 IRQ_TYPE_EDGE_RISING>;
> +		pinctrl-0 = <&csi0_imu_int1>;

After double checking everything, we need an additional two pins driven 
via pinctrl to 1) guarantee the state of a bootstrapping pin to select 
SPI/I2C mode, 2) guarantee the state of a bootstrapping pin to select 
the I2C address.

> +		pinctrl-names = "default";
> +		vdd-supply = <&vcc_2v8_imu>;
> +		vddio-supply = <&vcc_1v8_s3>;
> +	};
> +};
> +
> +&pinctrl {
> +	cam0_p14 {

The review LLM highlighted this, where I should use a dash instead of 
underscore in node names, will fix for v2.

I'll wait a few more days for additional feedback before sending a v2.

Cheers,
Quentin