Re: [PATCH v3 5/5] media: qcom: camss: Add support for Hawi

[Bryan O'Donoghue]

On 04/11/2026 16:11, Loic Poulain wrote:
> > > We have a series from Antans to address this though.
> > >
> > > We should list the clocks the SoC supports not constrain that list for
> > > one specific sensor on a test-case.
> > >
> > > ---
> > > bod
> > Good to know that Antans has a series addressing this. I agree that we
> > should list all the clock rates supported by the SoC rather than
> > constraining them for a specific sensor.
> >
> > One additional concern: if the clock selection logic still always picks
> > freq[0], listing a lower rate first could leave CAMSS unable to work
> > properly with sensors that need higher bandwidth.
> >
> > Could you please share the link to the series? I'll rebase the next
> > revision on top of it.
> I don't think Atanas' series targets the CSID clocks, only the VFE
> clocks. Ideally, we should make similar changes for the CSID clocks as
> well, but for now they are not being considered here.
>
> Perhaps add a few comments documenting the supported rates and use a
> single rate for the time being. Once the CSID clock changes land, we
> should be able to revisit and adapt this accordingly?

Its the same principle though.

I don't think there's a valid case to exclude clock-rates purely because 
one sensor requires the higher rate and we aren't willing to do the work 
to make the clocks smarter.

---
bod