Re: [PATCH] kho: Remove redundant 0x prefixes

[Arnd Bergmann]

On Wed, Nov 4, 2026, at 17:09, Thorsten Blum wrote:
> The %pa format specifier already includes the 0x prefix. Remove the
> redundant prefixes to avoid printing 0x0x.
>
> Fixes: c609c144b0e8 ("kexec: add KHO parsing support")
> Signed-off-by: Thorsten Blum <blum@xxxxxxxxxx>

Hi Thorsten,

The change looks correct, but I see another problem in the same line:

>  		if (err) {
> -			pr_warn("failed to mark the bootmem region 0x%pa+0x%pa: %pe",
> +			pr_warn("failed to mark the bootmem region %pa+%pa: %pe",
>  				&area->addr, &size, ERR_PTR(err));

'size' is a 'u64', not a phys_addr_t, so the pr_warn will print the wrong
on some platforms. Can you change this to use 0x%llx instead, or change
the type of the temporary variable to phys_addr_t instead?

     Arnd