Re: [PATCH net-next v2 1/7] bnxt_en: let the stack segment GSO skbs with too many frags
From: Michael Chan
Date: Wed Nov 04 2026 - 12:47:35 EST
On Tue, Nov 3, 2026 at 3:51 PM Stanislav Fomichev <sdf.kernel@xxxxxxxxx> wrote:
>
> With MAX_SKB_FRAGS > TX_MAX_FRAGS, the xmit path linearizes skbs with
> more frags than a packet can have BDs. For GSO skbs, linearizing needs a
> large allocation, can produce a head which doesn't fit in a BD with BIG
> TCP, and always fails for unreadable skbs. Clear the GSO features of
> such skbs in ndo_features_check instead, so that the stack segments
> them. Non-GSO skbs are still linearized.
>
> Suggested-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> Link: https://lore.kernel.org/all/CANn89i+ps_CozfOyRnKav0_LUmSekJ9ExB5JkDbTAVf_ss_98g@xxxxxxxxxxxxxx/
> Signed-off-by: Stanislav Fomichev <sdf@xxxxxxxxxxx>
Reviewed-by: Michael Chan <michael.chan@xxxxxxxxxxxx>
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature