Re: [PATCH v3 05/18] perf test: cs-etm: Increase window size in disassembly test

[James Clark]

On 04/11/2026 16:36, Leo Yan wrote:
> On Mon, Nov 02, 2026 at 12:15:19PM +0000, James Clark wrote:
> > When we increase the default timestamp interval in a later commit, less
> > trace will be recorded. At the moment the amount of trace overflows the
> > 64K buffer, so the exit snapshot trace is what happened at the end of
> > the process rather than the beginning. With the new default interval,
> > the entire execution will be contained in one buffer and the first few
> > samples are always various instruction and data faults. These go to the
> > kernel so don't result in ranges that can be disassembled.
> >
> > Increase the window to 6 samples to ensure something with a branch can
> > be disassembled even with the fault samples.
> >
> > Signed-off-by: James Clark <james.clark@xxxxxxxxxx>
>
> I don't mind to set even a bigger sample number (like 50). I did test
> and 50 samples just add 0.5s run time.
>
> Either is fine:
>
> Reviewed-by: Leo Yan <leo.yan@xxxxxxx>

I quite like keeping it small because it's more likely to catch a 
regression in the decoding. But we can increase it if there is some 
other reason in the future.