Re: [PATCH v2 1/1] spi: use dmaengine_desc_set_callback()

From: Florian Fainelli

Date: Wed Nov 04 2026 - 13:54:59 EST




On 11/4/2026 7:22 AM, Frank.Li@xxxxxxxxxxx wrote:
From: Frank Li <Frank.Li@xxxxxxx>

Replace open-coded assignments to callback and callback_param fields
of struct dma_async_tx_descriptor with calls to the
dmaengine_desc_set_callback() helper across SPI bus drivers.

No functional change intended. Prepare make to struct
dma_async_tx_descriptor private to the DMA engine.

Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>
Reviewed-by: Mukesh Kumar Savaliya <mukesh.savaliya@xxxxxxxxxxxxxxxx>
Acked-by: Alain Volmat <alain.volmat@xxxxxxxxxxx>
Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Reviewed-by: Troy Mitchell <troy.mitchell@xxxxxxxxxxxxxxxxxx>
Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
Acked-by: Thierry Reding <treding@xxxxxxxxxx>
Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
---
change in v2
- add missed set_callback in rspi_dma_transfer() (sashiko
- collect review by tags
- drop void *
---
drivers/spi/atmel-quadspi.c | 3 +--
drivers/spi/spi-at91-usart.c | 3 +--
drivers/spi/spi-atcspi200.c | 3 +--
drivers/spi/spi-atmel.c | 3 +--
drivers/spi/spi-bcm2835.c | 6 ++----

For the above:

Reviewed-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
--
Florian