[PATCH 00/10] regulator: Fix teardown races, reference counting, and error handling

[Lee Jones]

These issues were reported by Sashiko.

This series addresses ten bugs across the regulator core and regulator
drivers:

- Clear the caller's handle pointer (*handle = NULL) in
  regulator_irq_helper_cancel() instead of assigning NULL to the local
  variable.
- Remove the redundant arizona_ldo1_remove() callback that caused a
  premature and double gpiod_put() on config.ena_gpiod (whose lifetime
  is owned by the regulator core).
- Flush rdev->disable_work with flush_delayed_work() before releasing
  rdev->supply in regulator_unregister().
- Cancel micsupp->check_cp_work on device teardown in arizona-micsupp
  using devm_work_autocancel().
- Take a dedicated device reference for rdev->supply in set_supply() and
  retain the local lookup reference throughout regulator_resolve_supply().
- Initialise rdev->last_off with ktime_get_boottime() in
  set_machine_constraints() to match _regulator_do_enable() and
  _regulator_do_disable().
- Propagate GPIO lookup errors (such as -EPROBE_DEFER) from
  bq257xx_reg_dt_parse_gpio() instead of leaving an ERR_PTR in
  pdata->otg_en_gpio.
- Fix the LDO4 n_voltages count in tps6594-regulator so selectors 0x3f
  through 0x74 are reachable.
- Guard against a NULL idata pointer for BBAT, SDBY, and VRTC in
  max8907_regulator_probe().
- Check the pm_runtime_resume_and_get() return value in
  rt6190_out_enable().

Cc: "André Draszik" <andre.draszik@xxxxxxxxxx>
Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Cc: Bartosz Golaszewski <brgl@xxxxxxxxxx>
Cc: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
Cc: ChiYuan Huang <cy_huang@xxxxxxxxxxx>
Cc: Chris Morgan <macromorgan@xxxxxxxxxxx>
Cc: Douglas Anderson <dianders@xxxxxxxxxxxx>
Cc: Eduardo Candelaria <jedu@xxxxxxxxxxxxxxx>
Cc: Esteban Blanc <eblanc@xxxxxxxxxxxx>
Cc: Graeme Gregory <gg@xxxxxxxxxxxxxxx>
Cc: Gyungoh Yoo <jack.yoo@xxxxxxxxxxxx>
Cc: Jerome Neanne <jneanne@xxxxxxxxxxxx>
Cc: Jiale Yao <yaojiale02@xxxxxxx>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
Cc: Laxman Dewangan <ldewangan@xxxxxxxxxx>
Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>
Cc: Linus Walleij <linusw@xxxxxxxxxx>
Cc: Mal Nadar <m.nirmaladevi@xxxxxxxx>
Cc: Mark Brown <broonie@xxxxxxxxxx>
Cc: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
Cc: Stephen Warren <swarren@xxxxxxxxxx>
Cc: Uday Khare <udaykhare77@xxxxxxxxx>
Cc: Wentao Liang <vulab@xxxxxxxxxxx>
Cc: linux-gpio@xxxxxxxxxxxxxxx
Cc: patches@xxxxxxxxxxxxxxxxxxxxx

Lee Jones (10):
  regulator: irq_helpers: Clear caller handle in
    regulator_irq_helper_cancel()
  regulator: arizona-ldo1: Avoid double gpiod_put() on enable GPIO
  regulator: core: Flush delayed disable_work before releasing supply in
    regulator_unregister()
  regulator: arizona-micsupp: Cancel check_cp_work on device teardown
  regulator: core: Hold supply device reference until constraints are
    resolved in regulator_resolve_supply()
  regulator: core: Use ktime_get_boottime() in set_machine_constraints()
  regulator: bq257xx: Propagate GPIO error in
    bq257xx_reg_dt_parse_gpio()
  regulator: tps6594-regulator: Fix LDO4 n_voltages in tps6594_ldo_regs
  regulator: max8907: Avoid NULL idata dereference in
    max8907_regulator_probe()
  regulator: rt6190: Check pm_runtime_resume_and_get() return value in
    rt6190_out_enable()

 drivers/regulator/arizona-ldo1.c      | 16 ----------------
 drivers/regulator/arizona-micsupp.c   |  6 +++++-
 drivers/regulator/bq257xx-regulator.c | 20 ++++++++++++--------
 drivers/regulator/core.c              | 22 ++++++++++++----------
 drivers/regulator/irq_helpers.c       |  2 +-
 drivers/regulator/max8907-regulator.c |  3 ++-
 drivers/regulator/rt6190-regulator.c  |  4 +++-
 drivers/regulator/tps6594-regulator.c |  2 +-
 8 files changed, 36 insertions(+), 39 deletions(-)


base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
-- 
2.56.0.385.gac671c819a-goog