Re: [PATCH v9 11/13] drm/mediatek: mtk_dsi: Enable PM Runtime on probe
From: Roman Vivchar
Date: Wed Nov 04 2026 - 14:52:23 EST
On Wednesday, September 16th, 2026 at 2:09 PM, AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> wrote:
> Enable PM Runtime at the end of mtk_dsi_probe() so that the
> mediatek-drm mtk_ddp_comp_power_on() function is able to do
> pm_runtime_resume_and_get() and, analogously, the function
> mtk_ddp_comp_power_off() to pm_runtime_put() for the DSI
> device.
>
> This makes sure that the power domains for the DSI IP are
> turned on and off when necessary.
>
> Reviewed-by: CK Hu <ck.hu@xxxxxxxxxxxx>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
No regressions on mt6595 or mt6768 platform.
Tested-by: Roman Vivchar <rva333@xxxxxxxxxxxxxx> # mt6595, mt6768
Best regards,
Roman
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 3b33419aee2d..4863d910511e 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1735,6 +1735,10 @@ static int mtk_dsi_probe(struct platform_device *pdev)
> if (ret)
> return dev_err_probe(&pdev->dev, ret, "Failed to request DSI irq\n");
>
> + ret = devm_pm_runtime_enable(dev);
> + if (ret)
> + return ret;
> +
> ret = mipi_dsi_host_register(&dsi->host);
> if (ret < 0)
> return dev_err_probe(dev, ret, "Failed to register DSI host\n");
> --
> 2.55.0
>
>
>