Re: [PATCH] firmware: cs_dsp: Fix memory leak on cs_dsp_power_up() error path

From: Mark Brown

Date: Wed Nov 04 2026 - 15:52:09 EST


> If cs_dsp_power_up() fails on or after cs_dsp_load() mark the controls
> disabled and free the alg regions.

> @@ -2838,6 +2839,11 @@ int cs_dsp_power_up(struct cs_dsp *dsp,
>
> return 0;
> err_ena:
> + list_for_each_entry(ctl, &dsp->ctl_list, list)
> + ctl->enabled = 0;
> +
> + cs_dsp_free_alg_regions(dsp);
> +

Do we need something similar in cs_dsp_adsp1_power_up() as well?

--
Mark Brown <broonie@xxxxxxxxxx>