Re: [PATCH 1/1] crypto: use dmaengine_desc_set_callback()

[Andy Shevchenko]

On Wed, Nov 04, 2026 at 06:51:10PM +0100, Krzysztof Kozlowski wrote:
> On 02/11/2026 17:45, Frank.Li@xxxxxxxxxxx wrote:

> > diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c
> > index 84392411b98d8..49f1bf19747d8 100644
> > --- a/drivers/crypto/atmel-aes.c
> > +++ b/drivers/crypto/atmel-aes.c
> > @@ -824,8 +824,7 @@ static int atmel_aes_dma_transfer_start(struct atmel_aes_dev *dd,
> >  	if (!desc)
> >  		return -ENOMEM;
> >  
> > -	desc->callback = callback;
> > -	desc->callback_param = dd;
> > +	dmaengine_desc_set_callback(desc, callback, NULL, dd);
> >  	dmaengine_submit(desc);
> >  	dma_async_issue_pending(dma->chan);
> >  
> 
> Apparently reviewing only a few lines of entire patch is still reviewing:
> https://lore.kernel.org/all/9e39502a-dd17-4fa2-98a3-9019523cb5e8@xxxxxxxxxx/
> 
> Therefore:
> Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Yep, in a form of

  Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> # atmel-aes

or something that makes it clear what has been reviewed.

-- 
With Best Regards,
Andy Shevchenko