Re: [PATCH] pinctrl: starfive: jhb100: use str_enable_disable()

[Changhuang Liang]

> Replace the open coded ternary in the jhb100_irq_set_wake() function with
> the helper from string_choices.h. Gives same output.
> 
> Signed-off-by: Aryan Sinha <sinha.aryan03@xxxxxxxxx>

Reviewed-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>

Best Regards,
Changhuang

> ---
>  drivers/pinctrl/starfive/pinctrl-starfive-jhb100.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jhb100.c
> b/drivers/pinctrl/starfive/pinctrl-starfive-jhb100.c
> index 462a26697..329153876 100644
> --- a/drivers/pinctrl/starfive/pinctrl-starfive-jhb100.c
> +++ b/drivers/pinctrl/starfive/pinctrl-starfive-jhb100.c
> @@ -20,6 +20,7 @@
>  #include <linux/seq_file.h>
>  #include <linux/spinlock.h>
>  #include <linux/string.h>
> +#include <linux/string_choices.h>
> 
>  #include <linux/pinctrl/consumer.h>
>  #include <linux/pinctrl/pinconf.h>
> @@ -1152,7 +1153,7 @@ static int jhb100_irq_set_wake(struct irq_data *d,
> unsigned int enable)
>  		ret = disable_irq_wake(sfp->irq);
>  	if (ret)
>  		dev_err(sfp->dev, "failed to %s wake-up interrupt\n",
> -			enable ? "enable" : "disable");
> +			str_enable_disable(enable));
> 
>  	return ret;
>  }
> --
> 2.46.0