[PATCH v3 0/4] phy: rockchip: inno-usb2: ensure PHY is running when clock is requested
From: Sebastian Reichel
Date: Wed Nov 04 2026 - 20:32:54 EST
This was noticed on RK3588 EVB1 when resuming from system suspend. This
is technically a fix, but its unclear when the bug was introduced and
system suspend is broken on RK3588 for quite a while and not just due
to this problem. So I think this fix can be merged the normal way via
linux-next.
Changes in v3:
- Link to v2: https://patch.msgid.link/20261001-phy-rockchip-inno-usb2-clock-fix-v2-0-e01bf509359e@xxxxxxxxxxxxx
- Fix do_suspend negation resulting in SError on RK3576 (Sashiko, CI testing)
- Ensure PHY ports array is initialized in clock enable path (Sashiko)
- Cleanup properly in clock enable error path (Sashiko)
Changes in v2:
- Link to v1: https://patch.msgid.link/20260908-phy-rockchip-inno-usb2-clock-fix-v1-1-f7d59c31b908@xxxxxxxxxxxxx
- Move suspend exit code from rockchip_usb2phy_power_on into a
separate patch and reuse it in the clock prepare function;
move is done in a separate patch
- Updated commit messages with proper rationale
- Added one more patch dropping useless assignment
of rport->suspended directly after calling
rockchip_usb2phy_power_on/off
- Add one more patch unifying and simplifying the debug
messages for phy init/power_on/power_off/exit
---
To: Vinod Koul <vkoul@xxxxxxxxxx>
To: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
To: Manivannan Sadhasivam <mani@xxxxxxxxxx>
To: Heiko Stuebner <heiko@xxxxxxxxx>
Cc: linux-phy@xxxxxxxxxxxxxxxxxxx
Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
Cc: linux-rockchip@xxxxxxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Cc: Igor Paunovic <royalnet026@xxxxxxxxx>
Cc: kernel@xxxxxxxxxxxxx
Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
---
Sebastian Reichel (4):
phy: rockchip: inno-usb2: simplify and unify PHY op debug messages
phy: rockchip: inno-usb2: drop duplicated update of rport->suspended
phy: rockchip: inno-usb2: move suspend handling into new function
phy: rockchip: inno-usb2: move suspend handling into clock prepare/unprepare for RK3588/RK3576
drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 92 +++++++++++++++++++--------
1 file changed, 66 insertions(+), 26 deletions(-)
---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20260908-phy-rockchip-inno-usb2-clock-fix-edd65b57f884
Best regards,
--
Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>