Re: [PATCH 3/4] media: qcom: camss: Add support for SM8150
From: Andrew Gigena
Date: Wed Nov 04 2026 - 20:44:04 EST
Hi Val,
Thanks for the review, and great timing on the SC8180X work.
> It should probably go higher in the sort order, before 8250?
Agreed. I’ve moved them for the next version.
> Interesting, why do these match 8280xp and not, say, 8250?
SM8150’s downstream DT describes the PHY as qcom,csiphy-v1.1, and the
v1.1 2PH (D-PHY) lane sequence in cam_csiphy_1_1_hwreg.h matches the
2PH entries in lane_regs_sc8280xp offset-for-offset:
- 0x0004, 0x002C, 0x0034, 0x001C, 0x0014, 0x0028, 0x003C, 0x0000,
0x0008, 0x000C, 0x0010, 0x0038, 0x0060, 0x0064
- lane blocks at 0x0704, 0x0204, 0x0404, 0x0604
- with 0x0728 = 0x04, 0x0700 = 0x80, 0x070C = 0xA5, 0x0738 = 0x1F
The SM8250 lane_regs_sm8250 table is a different sequence (0x0030,
0x0900/0x0908, 0x0034 = 0x07, 0x0010 = 0x02, etc.), so it doesn’t fit
the v1.1 PHY. If SC8180X uses the same v1.1 CSIPHY, the SC8280XP lane
table should be the right starting point there too.
See https://android.googlesource.com/kernel/msm/+/refs/heads/android-msm-coral-4.14-android13/drivers/media/platform/msm/ais/cam_sensor_module/cam_csiphy/include/cam_csiphy_1_1_hwreg.h
El mié, 4 nov 2026 a la(s) 6:19 p.m., Val Packett (val@xxxxxxxxxxxx) escribió:
>
> Hi,
>
> On 11/4/26 5:54 PM, Andrew Gigena via B4 Relay wrote:
> > From: Andrew Gigena <mail@xxxxxxxxxxxxxxxx>
> >
> > Add CAMSS platform data for the Qualcomm SM8150 SoC. The camera
> > subsystem contains four CSIPHY, four CSID (two full and two lite), two
> > VFE and two VFE-Lite instances.
> >
> > The hardware reuses the existing 3-phase 1.0 CSIPHY, Gen2 CSID and
> > VFE 17x implementations; the CSIPHY uses the SC8280XP lane register
> > layout. Add CAMSS_8150 to the version enum and to the shared code
> > paths, then add the per-block clock, regulator, power domain,
> > interrupt and interconnect resources.
> >
> > Signed-off-by: Andrew Gigena <mail@xxxxxxxxxxxxxxxx>
> > ---
> Wow, what an unbelievable coincidence — I just went looking for this and
> found these patches on gitlab in order to test on the similar sc8180x,
> and half an hour later you've submitted it to the lists! :D
> > .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 2 +
> > drivers/media/platform/qcom/camss/camss-vfe.c | 2 +
> > drivers/media/platform/qcom/camss/camss.c | 262 +++++++++++++++++++++
> > drivers/media/platform/qcom/camss/camss.h | 1 +
> > 4 files changed, 267 insertions(+)
> >
> > diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> > index dac8d2ecf799..851decb0691e 100644
> > --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> > +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> > @@ -1141,6 +1141,7 @@ static bool csiphy_is_gen2(u32 version)
> > case CAMSS_8650:
> > case CAMSS_8775P:
> > case CAMSS_X1E80100:
> > + case CAMSS_8150:
> It should probably go higher in the sort order, before 8250?
> > ret = true;
> > break;
> > }
> > @@ -1236,6 +1237,7 @@ static int csiphy_init(struct csiphy_device *csiphy)
> > regs->lane_array_size = ARRAY_SIZE(lane_regs_sm8250);
> > break;
> > case CAMSS_8280XP:
> > + case CAMSS_8150:
> > regs->lane_regs = &lane_regs_sc8280xp[0];
> > regs->lane_array_size = ARRAY_SIZE(lane_regs_sc8280xp);
> > break;
> Interesting, why do these match 8280xp and not, say, 8250?
> > diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
> > index 2680a9914765..dd28058e98a7 100644
> > --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> > +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
> > @@ -354,6 +354,7 @@ static u32 vfe_src_pad_code(struct vfe_line *line, u32 sink_code,
> > case CAMSS_8650:
> > case CAMSS_8775P:
> > case CAMSS_X1E80100:
> > + case CAMSS_8150:
> Sort order here too
> > switch (sink_code) {
> > case MEDIA_BUS_FMT_YUYV8_1X16:
> > {
> > @@ -2010,6 +2011,7 @@ static int vfe_bpl_align_rdi(struct vfe_device *vfe)
> > case CAMSS_8280XP:
> > case CAMSS_8300:
> > case CAMSS_845:
> > + case CAMSS_8150:
> > case CAMSS_8550:
> > case CAMSS_8650:
> > case CAMSS_8775P:
> > [..]
>
>
> Thanks,
> ~val
>
>