回复: [PATCH] ASoC: sn624x: use dev_err_probe() for the regmap failure

[qianghua.wang]

On Thu, 5 Nov 2026, Aryan Sinha wrote:
> dev_err_probe() prints the symbolic errno and stays quiet on
> -EPROBE_DEFER. ...

Acked-by: Qianghua Wang <qianghua.wang@xxxxxxxxxxxxxx>

Qianghua Wang

Email: qianghua.wang@xxxxxxxxxxxxxx
Website: https://www.senarytech.com      

-----Original Message-----
From: Aryan Sinha sinha.aryan03@xxxxxxxxx
Sent: November 4, 2026 23:02
To: bo liu bo.liu@xxxxxxxxxxxxxx; qianghua . wang qianghua.wang@xxxxxxxxxxxxxx
Cc: Mark Brown broonie@xxxxxxxxxx; Liam Girdwood lgirdwood@xxxxxxxxx; linux-sound@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Aryan Sinha sinha.aryan03@xxxxxxxxx
Subject: [PATCH] ASoC: sn624x: use dev_err_probe() for the regmap failure

dev_err_probe() prints the symbolic errno and stays quiet on  -EPROBE_DEFER. The sn624x prefix goes too, dev_err_probe() already prints the device name..

Signed-off-by: Aryan Sinha <sinha.aryan03@xxxxxxxxx>
---
 sound/soc/codecs/sn624x-sdca-sdw.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/sound/soc/codecs/sn624x-sdca-sdw.c b/sound/soc/codecs/sn624x-sdca-sdw.c
index c9e690482..1a83f0a11 100644
--- a/sound/soc/codecs/sn624x-sdca-sdw.c
+++ b/sound/soc/codecs/sn624x-sdca-sdw.c
@@ -1736,11 +1736,9 @@ static int sn624x_sdca_sdw_probe(struct sdw_slave *slave,
 	regmap = devm_regmap_init_sdw_mbq_cfg(&slave->dev, slave,
 					      &sn624x_sdca_regmap,
 					      &sn624x_sdca_mbq_cfg);
-	if (IS_ERR(regmap)) {
-		dev_err(&slave->dev, "sn624x: devm_regmap_init_sdw_mbq_cfg failed (%ld)\n",
-			PTR_ERR(regmap));
-		return PTR_ERR(regmap);
-	}
+	if (IS_ERR(regmap))
+		return dev_err_probe(&slave->dev, PTR_ERR(regmap),
+				     "devm_regmap_init_sdw_mbq_cfg failed\n");
 
 	ret = sn624x_sdca_init(&slave->dev, regmap, slave);
 	if (ret < 0)
--
2.46.0