Re: [PATCH v2 2/2] tty: serial: 8250: replace chan->device->dev with dmaengine_get_provider_device()

[Andy Shevchenko]

On Wed, Nov 04, 2026 at 09:52:07AM -0500, Frank.Li@xxxxxxxxxxx wrote:

> Use the dmaengine_get_provider_device() API instead of directly
> accessing chan->device->dev to get the DMA provider device.
> 
> No functional change. Prepare make to struct dma_device private to the DMA
> engine.

...

> -	if (s->dma_dev != chan->device->dev || s->chan_id != chan->chan_id)
> +	if (s->dma_dev != dmaengine_get_provider_device(chan) || s->chan_id != chan->chan_id)

Now it's better to wrap (I think the file doesn't really use relaxed limit of
100 characters per line).

	if (s->dma_dev != dmaengine_get_provider_device(chan) ||
	    s->chan_id != chan->chan_id)

>  		return false;

But TBH I don't care much, so
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko