Re: [PATCH] scripts: make_fit: propagate compressor failures

[Simon Glass]

On 2026-11-03T16:42:06, Hamdy Abou El Anein <info@xxxxxxxxxxxxxxxx> wrote:
> scripts: make_fit: propagate compressor failures
>
> compress_data() ignores the compressor exit status and marks the
> operation successful even if the tool wrote only partial output.
> build_fit() can then place that truncated data into a FIT image.
>
> Use check_call() so compressor failures abort image generation.
> FileNotFoundError still allows trying the next supported executable.
>
> Tested a compressor that writes partial output and exits with status
> 23: compression raises CalledProcessError and the CLI creates no FIT.
> Also generated uncompressed and gzip FIT images with a real DTB and
> ramdisk, and verified their payloads through libfdt and gzip.
>
> AI assistance: ChatGPT/Codex identified the issue and prepared the
> change, commit message and executable regression tests.
>
> Fixes: 7a23b027ec17 ("arm64: boot: Support Flat Image Tree")
> Signed-off-by: Hamdy Abou El Anein <hamdy.aea@xxxxxxxxxxxxxx>
>
>  scripts/make_fit.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@xxxxxxxxxxxx>