Re: [PATCH 1/2] dt-bindings: gpio: Add Siflower SF19A2890 GPIO controller

From: Joseph Telaak

Date: Wed Nov 04 2026 - 23:08:36 EST


> FYI, these other devices need their own compatible strings when a dts
> for them is added.

Understood. v2 describes only the SF19A2890, and support for the others
will come with compatibles of their own.

> > + reg:
> > + maxItems: 1
>
> Move this below compatible.

Will do.

> > + ngpios:
> > + description:
> > + The number of GPIOs available on the controller implementation.
> > + minimum: 1
>
> With no maximum?

v2 drops ngpios instead, since the compatible implies it: the driver
will take the 49 lines from its match data, and the binding will take
exactly four interrupts, one per 16 lines.

> Please fix the ordering here too.

Will do, in the same order as the properties.