Re: [PATCH] media: staging/ipu7: use guard(mutex) and simplify retry loop in buttress

[Dan Carpenter]

On Thu, Nov 05, 2026 at 12:28:32AM +0200, Laurian Iacob wrote:
> Use scope-based guard(mutex) from linux/cleanup.h in
> ipu_buttress_ipc_send_msg() and ipu_buttress_authenticate() to simplify
> error handling and remove redundant goto unlock paths.

Unfortunately, you didn't remove them all.

> 
> Additionally, replace the backward goto retry label in
> ipu_buttress_ipc_send_msg() with a standard for (;;) loop to improve
> control flow readability.

I don't like that you got rid of the try: label.  How is that related
to locking.

regards,
dan carpenter