Re: [PATCH 1/2] dt-bindings: media: qcom,glymur-camss: Use CSIPHY indices for ports

[Krzysztof Kozlowski]

On 05/11/2026 06:32, Nihal Kumar Gupta wrote:
>>
>> What is the problem exactly you are solving?
>>
> 
> The problem is that CSIPHY4 is connected to CAMSS interface 4, so the
> graph should describe it as port@4, not port@2.

Nothing like this is explained in commit msg.

> 
> The previous port@3 description only worked through the X1E80100 resource
> table indirection:
> 
>   port@3 -> csiphy_res[3] -> .csiphy.id = 4 -> CSID selects CSIPHY4
> 
> New standalone PHY path:
>   port@4 -> no csiphy_res[] lookup -> port number is id 4 -> CSID selects CSIPHY4

Then this breaks existing users, no? Anyway, what stops you from having
there proper mapping?

Did you find any existing practice of numbering ports logical numbering
in this device, but some other logic coming from datasheet? Where?


Best regards,
Krzysztof