Re: [PATCH] arm64: dts: qcom: sm8550: Add missing CPU7 3.36GHz OPP

[Konrad Dybcio]

On 11/4/26 10:24 PM, Val Packett wrote:
> 
> On 11/4/26 4:41 PM, Nizat Mikayilli via B4 Relay wrote:
>> From: Nizat Mikayilli <nacht@xxxxxxxxxx>
>>
>> The cpufreq LUT on the Samsung Galaxy Tab S9 Wi-Fi has a 3.36GHz boost
>> entry for CPU7 without a matching OPP, so the frequency is dropped:
>>
>> cpu cpu7: Voltage update failed freq=3360000
>> cpu cpu7: failed to update OPP for freq=3360000
>>
>> Fixes: 3f5dcc05cd33 ("arm64: dts: qcom: sm8550: add cpu OPP table with DDR, LLCC & L3 bandwidths")
>> Signed-off-by: Nizat Mikayilli <nacht@xxxxxxxxxx>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8550.dtsi | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> index 03f6d40edea7..ed6e34ac8d56 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> @@ -752,6 +752,11 @@ opp-3187200000 {
>>               opp-hz = /bits/ 64 <3187200000>;
>>               opp-peak-kBps = <(933000 * 16) (3686000 * 4) (1689600 * 32)>;
>>           };
>> +
>> +        opp-3360000000 {
>> +            opp-hz = /bits/ 64 <3360000000>;
>> +            opp-peak-kBps = <(933000 * 16) (3686000 * 4) (1689600 * 32)>;
>> +        };
>>       };
>>         pmu-a510 {
>>
> This seems variant/speedbin dependent and does not apply to all sm8550.
> 
> In fact a quick web search shows that your device has a "Snapdragon 8 Gen 2 for Galaxy" which is a customized chip for Smasnug.
> 
> You should just add the OPP in your tablet's .dts I think.

It's fine to have a superset of supported frequencies in this OPP table,
the frequencies available are retrieved from the LUT exposed by the
microcontroller anyway

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad