Re: [PATCH v2 1/2] KVM: arm64: Resume stage-2 teardown where the walk stopped

From: Fuad Tabba

Date: Thu Nov 05 2026 - 03:08:22 EST


On Wed, 4 Nov 2026 at 18:30, Oliver Upton <oupton@xxxxxxxxxx> wrote:
>
> Hi Fuad,
>
> On Wed, Nov 04, 2026 at 12:44:50PM +0000, Fuad Tabba wrote:
> > +u64 kvm_pgtable_stage2_destroy_range(struct kvm_pgtable *pgt,
> > + u64 addr, u64 size)
>
> Returning a signed value here would be a good idea so you can percolate
> walk failures back up to the caller. Since that WARN_ON() below may as
> well be a BUG_ON() in hyp code.

Ack.

> Otherwise, rest looks good.

Thanks Oliver!
/fuad