Re: [PATCH v2] docs: submitting-patches: Clarify half-baked review tags
From: Wolfram Sang
Date: Thu Nov 05 2026 - 03:54:08 EST
> +If the reviewer checks only a piece of the patch, leaving the rest unreviewed,
> +then more appropriate is Acked-by tag or adding a "# subpart-name" marker
"... is an Acked-by ..."?
> +after the Reviewed-by tag:
> +
> + Reviewed-by: I Did Not Read Everything <foo@xxxxxxxxxxx> # bar, baz
How about being more specific?
+ Reviewed-by: Driver X author <foo@xxxxxxxxxxx> # for Driver X
TBH, I think the above is even better than a generic "Acked-by" which is
basically "Yeah, I didn't look in detail but the general approach looks
fine". Which is not what the above says. The above says: "I didn't check
the general approach, but assuming it is okay, the changes to my driver
are correct". If I get a couple of those, then I know which parts have
been reviewed and which have not. A list of generic Acked-bys will not
provide that information. So, actually, I think even the Acked-by should
have the "# subpart name" once only a part of the patch has been looked
at. Ack/Rev is then describing the thoroughness of that look.
Do you get what I mean?