Re: [PATCH] pinctrl: realtek: Write the encoded slew rate value

[Linus Walleij]

On Sat, Oct 31, 2026 at 9:18 AM Baek Kyu, Kim <pocj8ur4in@xxxxxxxxx> wrote:

> rtd_pconf_parse_conf() maps slew-rate arguments 1, 10, 20 and 30 to the
> two-bit field values 0, 1, 2 and 3. However, it shifts the original
> argument into the register value instead of using the computed encoding.
> After masking, these arguments write 1, 2, 0 and 2 respectively. In
> particular, the distinct 10 and 30 settings write the same field value.
>
> Use set_val when constructing the register value so that both individual
> pin and group configuration apply the existing conversion. Leave argument
> validation, field offsets, masks and regmap error handling unchanged.
>
> Fixes: dcc9334435b0 ("pinctrl: realtek: add support for slew rate, input voltage and high VIL")
> Signed-off-by: Baek Kyu, Kim <pocj8ur4in@xxxxxxxxx>

Good find, patch applied!

Yours,
Linus Walleij