Re: [PATCH] regulator: as3722: use the platform OF node setter

[Bartosz Golaszewski]

On Thu, Nov 05, 2026 at 02:09:20AM +0800, Yige Jiang wrote:
> as3722_get_regulator_dt_data() gets the regulators child node and
> assigns it only to dev.of_node. Platform device release now puts
> dev.fwnode, leaving the acquired node reference unreleased.
> 
> Use platform_device_set_of_node() to synchronize both fields and
> give the device its own reference, then put the local lookup
> reference. This keeps the node valid for regulator matching and
> the platform device lifetime, while also replacing the previous
> device-owned reference on a probe retry.
> 
> Fixes: 7b5b51b2b05c ("driver core: platform: count references to all kinds of firmware nodes")
> Assisted-by: LLM
> Signed-off-by: Yige Jiang <yigejiang86@xxxxxxxxx>
> ---
> Based on linux-next next-20261102 (2637bdec0535).
> Compile-tested: arm64, GCC 14.2.0, W=1, CONFIG_OF_DYNAMIC=y.
> COMPILE_TEST=y.
> Baseline and patched target objects built from this exact base.
> No full kernel/module-link, hardware or runtime test was performed.
> AI assistance: Codex (LLM) for ownership analysis, code and changelog.
> 
> The earlier dangling-node fix is already present in this base.
> 
>  drivers/regulator/as3722-regulator.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/as3722-regulator.c b/drivers/regulator/as3722-regulator.c
> index 85e2aaa1a06b..9bf28e4b9821 100644
> --- a/drivers/regulator/as3722-regulator.c
> +++ b/drivers/regulator/as3722-regulator.c
> @@ -596,7 +596,8 @@ static int as3722_get_regulator_dt_data(struct platform_device *pdev,
>  		dev_err(&pdev->dev, "Device is not having regulators node\n");
>  		return -ENODEV;
>  	}
> -	pdev->dev.of_node = np;
> +	platform_device_set_of_node(pdev, np);
> +	of_node_put(np);
>  
>  	ret = of_regulator_match(&pdev->dev, np, as3722_regulator_matches,
>  			ARRAY_SIZE(as3722_regulator_matches));
>

Same comment as for the other patch, use __free(device_node).

Bart