Re: [PATCH v2 1/1] spi: use dmaengine_desc_set_callback()

[Krzysztof Kozlowski]

On 05/11/2026 10:20, Geert Uytterhoeven wrote:
> Hi Frank,
> 
> On Wed, 4 Nov 2026 at 16:30, <Frank.Li@xxxxxxxxxxx> wrote:
>> From: Frank Li <Frank.Li@xxxxxxx>
>>
>> Replace open-coded assignments to callback and callback_param fields
>> of struct dma_async_tx_descriptor with calls to the
>> dmaengine_desc_set_callback() helper across SPI bus drivers.
>>
>> No functional change intended. Prepare make to struct
>> dma_async_tx_descriptor private to the DMA engine.
>>
>> Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>
>> Reviewed-by: Mukesh Kumar Savaliya <mukesh.savaliya@xxxxxxxxxxxxxxxx>
>> Acked-by: Alain Volmat <alain.volmat@xxxxxxxxxxx>
>> Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
>> Reviewed-by: Troy Mitchell <troy.mitchell@xxxxxxxxxxxxxxxxxx>
>> Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
>> Acked-by: Thierry Reding <treding@xxxxxxxxxx>
>> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
>> ---
>> change in v2
>> - add missed set_callback in rspi_dma_transfer() (sashiko
>> - collect review by tags
>> - drop void *
> 
> You have lost the "# Renesas related drivers" part from Wolfram's
> review?
> https://lore.kernel.org/all/auoQiuIm9FxdOrYl@shikoro/

Yep. Also all of the reviews were partial reviews, but without "#
marker" part. Now entire commit is reviewed by five people! How great!

Best regards,
Krzysztof