Re: [PATCH 2/2] gpio: Add Siflower GPIO controller driver

[Linus Walleij]

Hi Joseph,

thanks for your patch!

On Wed, Nov 4, 2026 at 8:21 AM Joseph Telaak via B4 Relay
<devnull+joseph.telaak.dev@xxxxxxxxxx> wrote:


> +static u32 sf_gpio_rd(struct sf_gpio_priv *priv, unsigned long reg)
> +{
> +       return readl_relaxed(priv->base + reg);
> +}
> +
> +static void sf_gpio_wr(struct sf_gpio_priv *priv, unsigned long reg,
> +                      u32 val)
> +{
> +       writel_relaxed(val, priv->base + reg);
> +}

Completely pointless indirection, drop these functions, just use
readl/writel directly in the code.

Yours,
Linus Walleij