Re: [PATCH v1 1/1] i2c: designware: Add ACPI ID MSFT0006 for Microsoft Cobalt SoCs

From: Andy Shevchenko

Date: Thu Nov 05 2026 - 05:08:48 EST


On Wed, Nov 04, 2026 at 11:49:28PM +0000, Siddharth Chintamaneni wrote:
> Add the MSFT0006 ACPI ID for the DesignWare I2C controller integrated
> on Microsoft Cobalt SoCs, along with its 300 MHz input clock description
> in acpi_apd.c.
>
> Without an explicit MSFT0006 entry, ACPI device matching falls back to
> its _CID (APMC0D0F), which configures a 100 MHz input clock instead of
> the controller's actual 300 MHz clock.

> Cc: Jarred White <jarredwhite@xxxxxxxxxxxxx>
> Cc: Jeff Kirsher <jeff.kirsher@xxxxxxxxxxxxx>

Move Cc list after the '---' line below. It will reduce the noise in the commit
message and hence Git history.

> Signed-off-by: Siddharth Chintamaneni <sidchintamaneni@xxxxxxxxx>
> ---

Cc list goes here...

> drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
> 2 files changed, 7 insertions(+)

Code wise LGTM, I assume MS allocated that HID for the specific device and
we will not see collisions in the future.

--
With Best Regards,
Andy Shevchenko