Re: [PATCH v2 4/5] dt-bindings: display: panel: Add the HiBy LG35583

[H. Nikolaus Schaller]

Hi,

> Am 25.10.2026 um 20:16 schrieb Olivier Louvignes <olivier@xxxxxxxxx>:
> 
> The 480x800 parallel RGB panel of the HiBy R1, set up over a 3-wire SPI
> bus with 16-bit words.
> 
> Signed-off-by: Olivier Louvignes <olivier@xxxxxxxxx>
> ---
> .../bindings/display/panel/hiby,lg35583.yaml  | 71 +++++++++++++++++++
> MAINTAINERS                                   |  5 ++
> 2 files changed, 76 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/hiby,lg35583.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/hiby,lg35583.yaml b/Documentation/devicetree/bindings/display/panel/hiby,lg35583.yaml
> new file mode 100644
> index 000000000000..19498910629c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/hiby,lg35583.yaml
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/hiby,lg35583.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HiBy LG35583 480x800 panel
> +
> +maintainers:
> +  - Olivier Louvignes <olivier@xxxxxxxxx>
> +
> +description:
> +  The 480x800 parallel RGB panel of the HiBy R1, which HiBy calls the
> +  LG35583. It is set up over a 3-wire SPI bus with 16-bit words.

I have discussed with the Google AI and it hints at that the controller
is a Novatek NT35510 / NT35580 family or derivative.

It is possible to locate data sheets for comparing the lg35583_init[]
table...

> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> +  compatible:
> +    const: hiby,lg35583

But based on the scarce information I think it is the best solution to
stay with the hiby,lg35583 compatible.

> +
> +  reg:
> +    maxItems: 1
> +
> +  vcc-supply:
> +    description: Panel power supply
> +
> +  vccio-supply:
> +    description: I/O power supply
> +
> +  reset-gpios: true
> +  backlight: true
> +  port: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - vcc-supply
> +  - vccio-supply
> +  - reset-gpios
> +  - port
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@0 {
> +            compatible = "hiby,lg35583";
> +            reg = <0>;
> +            spi-max-frequency = <1000000>;
> +
> +            vcc-supply = <&vcc_lcd>;
> +            vccio-supply = <&vccio_lcd>;
> +            reset-gpios = <&gpa 31 GPIO_ACTIVE_LOW>;
> +            backlight = <&backlight>;
> +
> +            port {
> +                panel_in: endpoint {
> +                    remote-endpoint = <&lcd_out>;
> +                };
> +            };
> +        };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 57313163e59e..e65500a70c9d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8152,6 +8152,11 @@ S: Maintained
> T: git https://gitlab.freedesktop.org/drm/misc/kernel.git
> F: drivers/gpu/drm/tiny/gm12u320.c
> 
> +DRM DRIVER FOR HIBY LG35583 PANEL
> +M: Olivier Louvignes <olivier@xxxxxxxxx>
> +S: Maintained
> +F: Documentation/devicetree/bindings/display/panel/hiby,lg35583.yaml
> +
> DRM DRIVER FOR HIMAX HX8394 MIPI-DSI LCD panels
> M: Ondrej Jirman <megi@xxxxxx>
> M: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> -- 
> 2.39.5


BR and thanks,
Nikolaus