Re: [PATCH] serial: amba-pl011: touch the watchdogs in write_atomic()

[Breno Leitao]

On Thu, Nov 05, 2026 at 11:37:39AM +0100, Petr Mladek wrote:
> > --- a/drivers/tty/serial/amba-pl011.c
> > +++ b/drivers/tty/serial/amba-pl011.c
> > @@ -41,6 +41,7 @@
> >  #include <linux/sizes.h>
> >  #include <linux/io.h>
> >  #include <linux/acpi.h>
> > +#include <linux/nmi.h>
> >  
> >  #define UART_NR			14
> >  
> > @@ -2734,6 +2735,9 @@ pl011_console_write_atomic(struct console *co, struct nbcon_write_context *wctxt
> >  	struct uart_amba_port *uap = amba_ports[co->index];
> >  	unsigned int old_cr = 0;
> >  
> > +	/* An atomic flush may print a long backlog with IRQs disabled. */
> > +	touch_nmi_watchdog();
> > +
> 
> I would personally touch the watchdog at the end before returning from
> the function because it still could spend some non-trivial time
> in this function.

Ack, let me move it as you've just suggested, given I have no preference
at all. I will respin it soon.

Thanks for the review,
--breno