Re: [PATCH v4 2/3] iio: light: gp2ap002: add led power supply

[chr[]]

Hi Andy,

Am 04.11.26 um 18:31 schrieb Andy Shevchenko:
> Missing '---' cutter line which makes this patch invalid and it may not be
> applied (your SoB should be a tag and it should be last in the chain; you may
> conduct an experiment, take the message ID of this email, run on a clean Linux
> kernel Git repository something like `b4 am -s $MSG_ID; git am ...` followed by
> `git log`, you will see the issue).

Sorry. I ran checkpatch.pl and b4 check and they missed my mess ...

> >   	int num_chan;
> >   	const char *compat;
> >   	u8 val;
> > -	int ret;
> > +	int ret, vdd_volt;
>
> Don't mix semantically different variables on the same line.
> Try to keep reversed xmas tree order.

So like this:
	...
	const char *compat;
	int vdd_volt;
	u8 val;
	int ret;


> >   	if (ret) {
> > -		dev_err(dev, "failed to sett VDD voltage\n");
> > +		dev_err(dev, "failed to set VDD voltage\n");
> >   		return ret;
>
> Unrelated change.

Yes, but I'd still like to fix it. Ok, if I mention it in the changelog?
Or shall I drop this?

regards,

chris