Re: [PATCH] staging: most: video: document lock fields

From: Dan Carpenter

Date: Thu Nov 05 2026 - 07:58:29 EST


On Thu, Nov 05, 2026 at 10:12:22AM +0000, Hussain Sitamouwala wrote:
> Fix checkpatch.pl checks:
>
> CHECK: spinlock_t definition without comment
> CHECK: struct mutex definition without comment
>
> Add a comment to each lock in struct most_video_dev describing what it
> protects. No functional change.
>
> Signed-off-by: Hussain Sitamouwala <husainsitamuwala21@xxxxxxxxx>
> ---
> drivers/staging/most/video/video.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
> index 3a0445ff62f4..d60be8a741ed 100644
> --- a/drivers/staging/most/video/video.c
> +++ b/drivers/staging/most/video/video.c
> @@ -33,14 +33,14 @@ struct most_video_dev {
> bool mute;
>
> struct list_head pending_mbos;
> - spinlock_t list_lock;
> + spinlock_t list_lock; /* protects pending_mbos */

What I want here is an audit of the locking. I imagine that the result
of the audit will be more than a two word summary.

regards,
dan carpenter