回覆: [PATCH net-next v5 2/7] dt-bindings: net: ftgmac100: Add AST2700 compatible

[Jacky Chou]

Hi Krzysztof

Thank you for your reply.

> > Add AST2700 to the FTGMAC100 compatible list and document that its
> > RMII RCLK gate matches the earlier Aspeed SoCs. Allow the reset line
> > for AST2700 as it follows the same reset requirements as AST2600.
> >
> > Require "phy-mode" to be present in the device tree when the AST2700
> > compatible is used, matching the driver's probe-time requirement.
> >
> > Add aspeed,ast2700-mac as a standalone compatible, consistent with the
> > other Aspeed compatibles.
> >
> > Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> 
> Your patch changed substantially, so dropping tag was appropriate.
> 

Got it. I will drop this in next version.

> > Signed-off-by: Jacky Chou <jacky_chou@xxxxxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml | 12
> > +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > index c870dd0bda7b..0a376b849a91 100644
> > --- a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > +++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > @@ -17,6 +17,7 @@ properties:
> >            - aspeed,ast2400-mac
> >            - aspeed,ast2500-mac
> >            - aspeed,ast2600-mac
> > +          - aspeed,ast2700-mac
> >
> >    reg:
> >      maxItems: 1
> > @@ -28,7 +29,7 @@ properties:
> >      minItems: 1
> >      items:
> >        - description: MAC IP clock
> > -      - description: RMII RCLK gate for AST2500/2600
> > +      - description: RMII RCLK gate for AST2500/2600/2700
> 
> So not valid for 2600?
> 
> >
> >    resets:
> >      maxItems: 1
> > @@ -80,12 +81,21 @@ allOf:
> >            contains:
> >              enum:
> >                - aspeed,ast2600-mac
> > +              - aspeed,ast2700-mac
> >      then:
> >        properties:
> >          resets: true
> >      else:
> >        properties:
> >          resets: false
> 
> Blank line here
> 

Agreed.

> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: aspeed,ast2700-mac
> > +    then:
> > +      required:
> > +        - phy-mode
> 
> Please constrain clocks.
> 

I will add constrain clock in next version.

- if:
      properties:
        compatible:
          contains:
            const: aspeed,ast2400-mac
    then:
      properties:
        clocks:
          maxItems: 1
        clock-names:
          maxItems: 1

  - if:
      properties:
        compatible:
          contains:
            enum:
              - aspeed,ast2500-mac
              - aspeed,ast2600-mac
              - aspeed,ast2700-mac
    then:
      properties:
        clocks:
          minItems: 1
          maxItems: 2
        clock-names:
          minItems: 1
          maxItems: 2

  - if:
      not:
        properties:
          compatible:
            contains:
              enum:
                - aspeed,ast2400-mac
                - aspeed,ast2500-mac
                - aspeed,ast2600-mac
                - aspeed,ast2700-mac
    then:
      properties:
        clocks: false
        clock-names: false

Thanks,
Jacky