Re: [PATCH 2/2] phy: siflower: Add SF19A2890 USB 2.0 PHY driver

[Philipp Zabel]

On Mi, 2026-11-04 at 02:21 -0500, Joseph Telaak via B4 Relay wrote:
> From: Chuanhong Guo <gch981213@xxxxxxxxx>
> 
> Add a driver for the USB 2.0 PHY of the Siflower SF19A2890. Powering it
> on enables its reference clock, releases its two resets and takes it
> out of sleep.
> 
> Signed-off-by: Chuanhong Guo <gch981213@xxxxxxxxx>
> [jt: from Chuanhong's siflower-7.1 branch, the SF19A2890 PHY only; reset
>  names "por" and "phy", dev_err_probe() for the resets, drop the unused
>  includes and drvdata, Kconfig dependencies and help, commit message,
>  subject]
> Signed-off-by: Joseph Telaak <joseph@xxxxxxxxxx>
> ---
>  drivers/phy/Kconfig                      |   1 +
>  drivers/phy/Makefile                     |   1 +
>  drivers/phy/siflower/Kconfig             |  12 +++
>  drivers/phy/siflower/Makefile            |   2 +
>  drivers/phy/siflower/phy-sf19a2890-usb.c | 143 +++++++++++++++++++++++++++++++
>  5 files changed, 159 insertions(+)
> 
[...]
> --- /dev/null
> +++ b/drivers/phy/siflower/phy-sf19a2890-usb.c
> @@ -0,0 +1,143 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#include <linux/clk.h>
> +#include <linux/io.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/phy/phy.h>
> +#include <linux/platform_device.h>
> +#include <linux/reset.h>
> +
> +#define USB_SLEEPM 0x4
> +
> +struct sf19a2890_usb_phy {
> +	struct device *dev;
> +	struct clk *phy_clk;
> +	struct reset_control *usb_phy_rst;
> +	struct reset_control *power_on_rst;

Since these two resets are always toggled together, consider using the
reset_control_bulk API for both.

regards
Philipp