Re: [PATCH v2] docs: submitting-patches: Clarify half-baked review tags

From: Krzysztof Kozlowski

Date: Thu Nov 05 2026 - 08:23:24 EST


On 05/11/2026 12:53, Andy Shevchenko wrote:
> On Thu, Nov 05, 2026 at 01:19:14PM +0200, Wolfram Sang wrote:
>>
>>>>> "Reviewed-by:, instead, indicates that *the patch* has been reviewed and
>>>>> found acceptable according to the Reviewer's Statement:"
>>>>
>>>> So, for the SPI patch: if someone spent time and reviewed the complex
>>>> core changes, but only 2 out of dozens of drivers, this would be an Ack
>>>> according to you. I would, however, understand that this person doesn't
>>>
>>> No, and I explained this in this commit msg. That person reviewed the
>>> MAIN concept of the patch.
>>
>> With that MAIN concept emphasized, I am okay with your reasoning and
>> agree. Before (I cite, upmost paragraph) "*the patch*" could be
>> interpreted as 100% of the patch (including dumb driver conversions).
>
> ...which may lead to discouragement of reviewing such a patch.
> At least that's how I read the point.

Why Ack instead of Review would discourage? Are you saying people give
Reviewed-by tags for incomplete reviews only because they want the credits?

Best regards,
Krzysztof