Re: [PATCH v4 2/3] dt-bindings: remoteproc: qcom,shikra-pas: Add iommus constraints

From: Krzysztof Kozlowski

Date: Thu Nov 05 2026 - 08:42:07 EST


On Wed, Nov 04, 2026 at 07:33:31PM +0530, Komal Bajaj wrote:
> Add iommus constraints for Shikra PAS compatible:
> - qcom,shikra-cdsp-pas: maxItems: 1
> - qcom,shikra-lpaicp-pas: minItems: 3, maxItems: 3
>
> CDSP uses single IOMMU stream, while LPAICP firmware uses three.
> These are needed to describe the firmware streams when Linux boots
> at EL2 without the hypervisor.
>
> Signed-off-by: Komal Bajaj <komal.bajaj@xxxxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> index 34a2f15e9361..8c8a7616d478 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> @@ -112,6 +112,8 @@ allOf:
> maxItems: 1
> firmware-name:
> maxItems: 1
> + iommus:
> + maxItems: 1
> power-domains:
> items:
> - description: CX power domain
> @@ -134,6 +136,9 @@ allOf:
> minItems: 2
> firmware-name:
> minItems: 2
> + iommus:
> + minItems: 3
> + maxItems: 3

You need to list the items.

Why maxItems? What is the limit defined by top-level?

Best regards,
Krzysztof