Re: [PATCH net-next 2/2] net: ethernet: mtk_eth_soc: skip page_pool for
From: Simon Horman
Date: Thu Nov 05 2026 - 09:33:57 EST
On Mon, Nov 02, 2026 at 12:48:46AM +0200, Sandeep Haemoon wrote:
> page_pool allocates order-0 pages and the pool is created with
> MTK_PP_MAX_BUF_SIZE. Rings that need larger buffers (9K jumbo or the
> HW-LRO rings) cannot use it. Only create/use a page_pool when
> ring->frag_size fits in a page; the large-buffer path already uses
> mtk_max_buf_alloc().
>
> This is required by the 9K support in the previous patch; the
> large-buffer path it relies on comes from the MediaTek downstream
> series.
>
> Link: https://github.com/mediatek/mtk-openwrt-feeds
> Signed-off-by: Sandeep Haemoon <sandeeph@xxxxxxxxxxx>
It may not be particularly important, but I do wonder
if the order of the patches in this patch-set should
be reversed: as it is 9k support seems to be added by 1/2
and fixed in 2/2.
That notwithstanding:
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>