Re: [PATCH net-next] net: phy: air_an8801: add WAKE_PHY Wake-on-LAN support

[tommy shih]

On Tue, Nov 03, 2026 at 09:29:14PM +0800, Andrew Lunn wrote:
> This is an interesting definition of WAKE_PHY.
>
> Are there any other drivers which use change in link to trigger a
> wake?

Not really among the PHY drivers. mxl-gpy enables the link state
change interrupt (PHY_IMASK_LSTC) in set_wol() when WAKE_PHY is
requested, but it does not register the PHY as a wakeup source
itself.

> How are you using it? Is your device plugged into a manages switch and
> you are making the managed switch down/up the link?

I don't have a concrete use case for it. Waking on link change does
not seem to be a common way to wake a system over Ethernet; magic
packet is the usual method.

> Is the hardware capable of waking just on link up? Is there any point
> waking up if the link goes down?

No, the AN8801R only has a single link change wake event, which
triggers on both link up and link down, so it cannot be limited to
link up. I agree that waking up on link down is of little use.

Thanks,
Tommy