Re: [PATCH] ASoC: SOF: amd: Load alternatively signed firmware with an "_l" suffix
From: Mario Limonciello
Date: Thu Nov 05 2026 - 09:39:22 EST
On 11/5/26 08:07, Mark Brown wrote:
On Thu, Nov 05, 2026 at 04:03:32PM +0200, Péter Ujfalusi wrote:
On 04/11/2026 23:53, Mario Limonciello wrote:
+ ret = amd_smn_read(0, MP0_C2PMSG_63_REG, &val);
+ if (ret) {
+ dev_err(sdev->dev, "failed to read PSP firmware signing type: %d\n", ret);
+ /* all ones means the register isn't accessible */
+ if (val == 0xffffffff)
+ return -EIO;
this would also merit an error print?
amd_smn_read() will convert this to -ENODEV anyway so that won't be
reached.
Oh yeah; that's dead code then, thanks. I'll respin to drop it.