Re: [PATCH v4 19/25] dmaengine: sdxi: Encode context start, stop, update, and sync descriptors

[Tycho Andersen]

Hi Nathan,

On Tue, Nov 03, 2026 at 08:50:00PM -0600, Nathan Lynch via B4 Relay wrote:
> +int sdxi_encode_cxt_start(struct sdxi_desc *desc,
> +			  const struct sdxi_cxt_start *params)
...
> +int sdxi_encode_cxt_stop(struct sdxi_desc *desc,
> +			  const struct sdxi_cxt_stop *params)
...
> +int sdxi_encode_cxt_upd(struct sdxi_desc *desc,
> +			const struct sdxi_cxt_upd *params)
...
> +int sdxi_encode_sync(struct sdxi_desc *desc, const struct sdxi_sync *params)
> +{

These four can't fail but return something, and their return values
are never checked or used. Maybe worth changing them to void.

Tycho