Re: [PATCH v3 02/11] gpio: vf610: simplify with irq_set_irq_wake()

[Frank Li]

On Thu, Nov 05, 2026 at 11:53:00AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
>
> Replace the manual enable/disable irq wake logic with a single call to
> irq_set_irq_wake() to simplify code.
>
> Reviewed-by: Daniel Baluta <daniel.baluta@xxxxxxx>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

>  drivers/gpio/gpio-vf610.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
> index adfa2c2d5873..c1c562071c0d 100644
> --- a/drivers/gpio/gpio-vf610.c
> +++ b/drivers/gpio/gpio-vf610.c
> @@ -189,10 +189,7 @@ static int vf610_gpio_irq_set_wake(struct irq_data *d, u32 enable)
>  	struct vf610_gpio_port *port =
>  		gpiochip_get_data(irq_data_get_irq_chip_data(d));
>
> -	if (enable)
> -		enable_irq_wake(port->irq);
> -	else
> -		disable_irq_wake(port->irq);
> +	irq_set_irq_wake(port->irq, enable);
>
>  	return 0;
>  }
>
> --
> 2.51.0
>
>